Martin

Results 95 comments of Martin

> Sorry for not getting around to responding sooner. We probably do with FSAC QuickFixes or possibly some analyzers but with all changes to FCS, we adapt. It might be...

Here is what I found out. Good news is that goto-symbol is working correctly with the FCS of this PR and the fix in FSAC's `fcsRangeToLspLocation` that I mentioned in...

> The nowarn PR which has landed has reworked #line directive management, can that help now? #line directive management is not really reworked, it is still the same flawed thing....

Hmm, I understand how this makes sense for the "warning waves", but does it mean there is no longer a way to do what the `WarningLevel` [documentation](https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/compiler-options/errors-warnings#warninglevel) says? *The WarningLevel...

Ah ok. That means we cannot use 5 or 6 for opt-in warnings.

Or is that MSBuild logic in the language specific targets, and we could keep the traditional logic for F#?

The problem are the [F# "opt-in warnings"](https://learn.microsoft.com/en-us/dotnet/fsharp/language-reference/compiler-options#opt-in-warnings). They are not shown unless enabled by `warnon`. Most of them, currently, have no level (are never checked against WarningLevel). To fit them...

I was actually wondering if we should not turn all these "default-off" warnings into infos. Advantages: - This fits better their nature, - They can still be turned on in...

I'd like to come back then to my [original proposal](https://github.com/dotnet/fsharp/issues/17901). That way there is no flooding, but more consistency with the F# documentation and with the C# behavior.