Martin

Results 95 comments of Martin

I like the functionality and the API. I am not sure about the name. "Binary search" is a well defined algorithm for arrays with a single return value. Just Map.search?...

This PR will be replaced by a clean new one

It seems to me the above is a bug different from the one in the OP. The [map constructor](https://github.com/dotnet/fsharp/blob/df43ab1ba88fbb968b0593f4fce9ee9741039870/src/FSharp.Core/map.fs#L732) is ``` new(elements: seq) = let comparer = LanguagePrimitives.FastGenericComparer

@brianrourkeboll Thanks for looking into this. > @Martin521 Is that not because `Animal`'s `IComparable.CompareTo` implementation just delegates to the concrete type's implementation, i.e., when `IComparable.CompareTo` is ultimately called, it will...

I am still not convinced. Yes, looking from inside the system, one can explain why cats and dogs cannot be compared. But as a user, I think it is reasonable...

Ok, I think I have to give in regarding c). Thanks for your persistance and all the details. Still, the current behavior (a runtime exception when putting apples and oranges...

> I guess it would probably be easier to just write an analyzer that _always_ warns whenever a type parameter with the `comparison` constraint is instantiated to an interface type,...

I added tags in line with the releases in the release folder. ``` > git tag -n 2024-10-02 Markdown version of the original latest FSharp 4.1 spec 2025-04-07 Added FS-1005...