fsharp icon indicating copy to clipboard operation
fsharp copied to clipboard

Scoped #nowarn

Open Martin521 opened this issue 1 year ago • 1 comments

Description

This is a draft PR (WiP) for a scoped #nowarn.

Checklist

  • [X] implementation for impl files
  • [X] draft RFC
  • [X] implementation for sig files
  • [X] check if scripts are covered
  • [X] handle #line directives correctly
  • [X] handle #line directives correctly, part 2
  • [X] relaxation of placement rules for the directives
  • [X] handle #line directives correctly, version 3
  • [ ] handle #line directives correctly, version 4
  • [x] implementation for service and interactive
  • [x] warning for invalid warn directive arguments
  • [ ] send the right trivia
  • [x] more tests
  • [X] RFC proposal, creation of discussion thread
  • [ ] RFC discussions and changes, possibly implementation changes, RFC approval and merge
  • [X] Release notes
  • [ ] re-create the PR, with digestible sequential commits
  • [ ] Notes for reviewers
  • [ ] Review

Post-merge checklist

  • [ ] Update the documentation as specified in the RFC
  • [ ] Further cleanup / refactoring around diagnostics

Martin521 avatar Aug 07 '24 20:08 Martin521

:heavy_exclamation_mark: Release notes required

@Martin521,

[!CAUTION] No release notes found for the changed paths (see table below).

Please make sure to add an entry with an informative description of the change as well as link to this pull request, issue and language suggestion if applicable. Release notes for this repository are based on Keep A Changelog format.

The following format is recommended for this repository:

* <Informative description>. ([PR #XXXXX](https://github.com/dotnet/fsharp/pull/XXXXX))

See examples in the files, listed in the table below or in th full documentation at https://fsharp.github.io/fsharp-compiler-docs/release-notes/About.html.

If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

You can open this PR in browser to add release notes: open in github.dev

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.200.md No release notes found or release notes format is not correct
LanguageFeatures.fsi docs/release-notes/.Language/preview.md No release notes found or release notes format is not correct

github-actions[bot] avatar Aug 07 '24 20:08 github-actions[bot]

This PR will be replaced by a clean new one

Martin521 avatar Nov 21 '24 21:11 Martin521