Maria

Results 181 comments of Maria

> Or more concrete, does this need to land in 3.15 or is it fine in 3.16? This is for 3.16

Katello seems to use `import * as settingActions from 'foremanReact/components/Settings/SettingsActions';` can you check if they still use it? and if not then create a PR in Katello to remove it

> Seems like Katello is using | import * as settingActions from 'foremanReact/components/Settings/SettingsActions'; and SettingsConstants SettingsConstants is still in Katello tests and the tests are failing with that

Katello test failures are not related, waiting for the other tests

Going over the PR, in the old page there is a status "Awaiting start" and I dont see it in the table/pr

I wouldnt CP it as it cant positively affect the application it self, this is only for tests

> Fair enough. This was causing you issues when you started to upgrade libraries? This was more noticeable when other tests were failing and I was looking into errors in...

Need to also fix integration test for this page

does it make sense to squash them? they're doing pretty different things