foreman_remote_execution icon indicating copy to clipboard operation
foreman_remote_execution copied to clipboard

Fixes #37630 - Display basic list of hosts on the new job_invocations page

Open kmalyjur opened this issue 1 year ago • 2 comments

image

Dependent on this PR.

The next PR will add sorting, filtering by status, and permission handling. The changes in the JobStatusIcon also affect the recent jobs card on the host detail page.

kmalyjur avatar Jul 04 '24 17:07 kmalyjur

Going over the PR, in the old page there is a status "Awaiting start" and I dont see it in the table/pr

MariaAga avatar Sep 02 '24 13:09 MariaAga

@MariaAga Thank you for your review! I incorporated everything except for If hostgroup is empty it shouldnt be a link, I think it's not necessary, but feel free to tell me otherwise.

I also made Fixes #37805 - Add possibility to display message when table is empty on which it's dependent.

kmalyjur avatar Sep 11 '24 13:09 kmalyjur

@MariaAga Could you please look at it again? I also incorporated some changes after @adamruzicka's review. Adam, could you please review the backend code?

kmalyjur avatar Oct 10 '24 13:10 kmalyjur

total (or subtotal) counts seem to be off once you start searching image

adamruzicka avatar Oct 23 '24 14:10 adamruzicka

Once you set a search, you can't really unset it. It won't allow you to submit the search if the searchbar is empty, although I can't really put my finger on where it comes from

adamruzicka avatar Oct 23 '24 14:10 adamruzicka

@adamruzicka thank you, I think I somehow broke it in the process :sweat_smile: should be fixed now

kmalyjur avatar Oct 31 '24 15:10 kmalyjur

Thank you @kmalyjur & @MariaAga !

adamruzicka avatar Nov 06 '24 12:11 adamruzicka