Maria

Results 181 comments of Maria

yeah so ` renderInPortal={false}` dealt with that cause then it just didnt render he portal so it couldnt create errors, but I guess there was a reason why things should...

No idea, some internal things for charts it seems? PF docs say: > When renderInPortal is true, rendered tooltips will be wrapped in VictoryPortal and rendered within the Portal element...

Fixed more tests but not sure what to do about the last 8 failing with this type of error as in some of them I do see the request being...

Fixed the notifications in foreman, and sub tabs in Katello. Also fixed the lint issues, will resolve the conflicts (once laptop will get unstuck :upside_down_face: )

CI failures are due to foreman-js pr not being merged/released, so the packages are wrong

Fixed select2 issue in foreman core

Yes I included your commit, the new test failures came from the new tests that were written meanwhile. Updated everything so this should be good to go in, tests pass...

> Navigating between frontend-rendered pages does not refresh the context. Currently (2024-09-24), this does not pose a problem for permission management, as every page that may grant permissions to users...

Tests (at least some) are failing since we mock the context in webpack/test_setup.js, so you can move the mock from ` jest.spyOn(foremanContextHooks, 'useForemanPermissions').mockImplementation(() => allPermissions)` to that file. Also an...

Also, I tried the wrapper and it works nicely! in webpack/assets/javascripts/react_app/components/HostDetails/Tabs/ReportsTab/index.js ```js const ReportsTabWrapper = props => ( ); export default ReportsTabWrapper; ```