theforeman
Fixes #38255 - Settings page table update to pf5
Hi, I checked on stream sn 93 + packit, overal it looks good, couple of notes:
- one big problem I see in updating encrypted items, when I edit such an item and submit, it shows up in the table unencrypted after that (when you do a full refresh on the page, then the value gets hidden as expected):
- minor annoyance, when there is a multliline content, it doesn't get bottom offset from the row border
Hi, I checked on stream sn 93 + packit, overal it looks good, couple of notes:
- one big problem I see in updating encrypted items, when I edit such an item and submit, it shows up in the table unencrypted after that (when you do a full refresh on the page, then the value gets hidden as expected):
- minor annoyance, when there is a multliline content, it doesn't get bottom offset from the row border
Encrypted items should be fixed. Bottom padding looks like is issue only in firefox browser, I will try to do some workaroud and find out why it is happening.
This PR depends on referenced PRs https://github.com/theforeman/foreman/pull/10531 https://github.com/theforeman/foreman/pull/10532
Or more concrete, does this need to land in 3.15 or is it fine in 3.16?
This is for 3.16
Katello seems to use import * as settingActions from 'foremanReact/components/Settings/SettingsActions'; can you check if they still use it? and if not then create a PR in Katello to remove it
Katello seems to use
import * as settingActions from 'foremanReact/components/Settings/SettingsActions';can you check if they still use it? and if not then create a PR in Katello to remove it
Fix in https://github.com/Katello/katello/pull/11414 Conflicts and rebase will be done after fix merge
Please read my comments as suggestions. I want to improve our system testing because the current status isn't great. A lot was written a long time ago, possibly predating the better APIs. I'd encourage you to NOT take Foreman's code as a best practice and make up your own mind by looking at the current best practices.
I found https://devhints.io/capybara to be very useful as well as the actions and matchers documentation.
None of this has to be a blocker, but we know that in the coming months we'll refactor a lot of frontend code and writing good regression tests will help with that.
Thank you for taking a deeper look into testing. Based on the suggestions and comments I will use more Minitest then RSpec assertions. I agree that we have to improve frontend and its testing.
Seems like Katello is using | import * as settingActions from 'foremanReact/components/Settings/SettingsActions'; and SettingsConstants
SettingsConstants is still in Katello tests and the tests are failing with that
Seems like Katello is using | import * as settingActions from 'foremanReact/components/Settings/SettingsActions'; and SettingsConstants
SettingsConstants is still in Katello tests and the tests are failing with that
https://github.com/Katello/katello/pull/11434