Maria

Results 181 comments of Maria

> @MariaAga how much work would it be to mark the date and time fields as incorrect? Also, I vaguely recall the form actively checking that the date is in...

In theory yes, but Im not sure its possible since it isnt a real field and the search works with: ```ruby scoped_search :on => :locked, :ext_method => :search_by_locked, ... def...

(most) tests are green, I dont think the codeclimate is related

Fixed the first 2 requests, thanks! > might it be necessary to make sure which tables will be affected? I dont think so, as I assume if a user want...

I will need to check PF suggestion: 0.2rem looks much closer to the old table .pf-v5-c-table.pf-m-compact { --pf-v5-c-table--cell--FontSize: var(--pf-v5-c-table--m-compact--FontSize); --pf-v5-c-table--cell--PaddingTop: var(--pf-v5-c-table--m-compact--cell--PaddingTop); --pf-v5-c-table--cell--PaddingBottom: var(--pf-v5-c-table--m-compact--cell--PaddingBottom); --pf-v5-c-table--cell--PaddingRight: var(--pf-v5-c-table--m-compact--cell--PaddingLeft); }

I dont have a preference This is how it looks with 2px padding: And this is with the proposed PF padding, which is 0.2 rem which turns to 3.2px:

@lumarel Thanks! I think we should keep it as 2px. I found way more results when searching our code base for `px;` then `em;` As for the actions hamburger I...

@adamruzicka this is also foreman_webhooks, katello (ModuleStreamsPage.js,FlatpakRemotesPage.js,HostReview.js, BootedContainerImagesPage.js ... ), OpenscapRemediationWizard, modals table and maybe more. Some of these places override the table wrapper and use the table directly from...

@aneta-petrova I added another change, and if it will be accepted I'll add details here :pray: