Marcono1234

@diffblue-assistant >into your existing source file My comment only described my personal opinion, I am neither a member nor contributor of this project. Though I think your proposed changes are...

> This is now superseded by #86 The only difference seems to be that this pull request also changes it so literals are parsed case-sensitively [here](https://github.com/Mojang/brigadier/pull/55/files#diff-d0001400ba816f0e4c1fae3df98645de141c05e8c17430966e76fb570817a716R56), though that might be...

What do you think about having separate methods for this modification instead? For example `ArgumentCommand` could have the methods * `addArgument(ArgumentType)` Adds the given argument type, which has to have...

JUnit 4 also has an `assertThrows` method since version 4.13, see https://github.com/junit-team/junit4/wiki/Exception-testing#using-assertthrows-method Also Brigadier uses the old Maven artifact coordinates for JUnit: `junit:junit-dep:4.11` It should switch (and update) to `junit:junit:4.13.2`

It appears that one of the `x` nodes is choosen (see also @NeunEinser's [comment](https://github.com/Mojang/brigadier/issues/38#issuecomment-431802706)). This could possibly be solved (unless I missed something) by adding a check to the [sorting](https://github.com/Mojang/brigadier/blob/447845ba89c1285cff0178afef082339c93c0ba5/src/main/java/com/mojang/brigadier/CommandDispatcher.java#L407)...

@tterrag1098, `Argument` should probably not extend `ArgumentType`. In my opinion this is only confusing since when used as such, the name is basically lost / ignored. And using an `enum`...

@IkeKap, no this issue is about arguments in the same path of a single command, for example: foo The problem here is that when the second `bar` argument is provided,...

Probably throwing an exception. Other solutions I can think of: - Ignoring it: Likely not what the programmer wants - Automatically renaming it: Likely also not wanted - Don't accessing...

Maybe it would be useful to have a `expectOption` overload which accepts some kind of Collection, for example List. Then the current implementation could call it with `expectOption(Arrays.asList(opts))` which is...

Sorry, I noticed that the cursor position is used when creating the exception. But do the other reading methods only reset it to make sure the cursor is at the...