Mojang
Add unit tests for StringReader.isAllowedInUnquotedString
The test cases contained in this PR were written by Diffblue's Diffblue Cover software. These tests are intended to help you detect regressions caused by future code changes.
One of our missions is to provide useful tests to open source projects. In return, we would appreciate your feedback on our tests to help us further improve our tool.
Results for various open source projects can be viewed at:
In my opinion the checks are too verbose, they could easily be written in one line, for example:
assertTrue(StringReader.isAllowedInUnquotedString('2'));
Additionally I doubt that the copyright header "Copyright (c) Diffblue Limited. All rights reserved." would work well for this project.
@Marcono1234 Many thanks for your feedback, we've merged the tests into your existing source file.
@Marcono1234 We've also now modified the tests to take into account your feedback regarding the verbosity.
@diffblue-assistant
into your existing source file
My comment only described my personal opinion, I am neither a member nor contributor of this project. Though I think your proposed changes are better now.