Marcono1234

Results 265 comments of Marcono1234

Because this renaming and usage of `InvocationInterceptor` is quite different from what I originally implemented here, I am closing this and have opened a separate PR for this: #676 That...

> [System Rules](https://stefanbirkner.github.io/system-rules/#RestoreSystemProperties) has `RestoreSystemProperties`. We could do something similar (using [`TypeBasedParameterResolver`](https://junit.org/junit5/docs/5.8.2/api/org.junit.jupiter.api/org/junit/jupiter/api/extension/support/TypeBasedParameterResolver.html)) Is the `SystemProperties` parameter really needed? Wouldn't it be easier and cover more cases, e.g. when the tested...

I am not very familiar with SonarCloud, but to me it sounds that these tokens should be kept private because they can be used for more than just to "ruin...

To me this sounds like you have carefully considered the consequences, so I don't mind if you want to close this issue since there seems to be no better alternative...

Adding a scripting language for this might be overkill. I was not clear enough about this, my idea is to call Minecraft functions when playing a note. These functions would...

Note that this is not only about fonts. Currently only characters whose code point is

After all this issue is only a suggestion (even though it did not sound like it). It is your project and you decide how it should be :) >Could you...

Why do the default implementations of the conversion methods without a scale parameter call the scale parameter ones? Shouldn't it be the other way around, since scaling is something which...

1. I think when the `@return` text is the same as the method description, as it is the case for `ImmutableStringReader.java`, then only `@return` should be used. Otherwise it is...

In my opinion the checks are too verbose, they could easily be written in one line, for example: assertTrue(StringReader.isAllowedInUnquotedString('2')); Additionally I doubt that the copyright header "Copyright (c) Diffblue Limited....