Manish Goregaokar

Results 596 comments of Manish Goregaokar

https://github.com/immersive-web/webxr-gamepads-module/issues/27

It seems like Gamepad told us to continue doing whatever we're doing so I'm not sure if there's anything more to be done here. We can potentially say we are...

Can we speed up merging this? Clippy CI is broken, and this affects clippy releases in nightly.

Either that or undo the changes to libtest in rustc until we have a better overall story for this here.

@jyn514 Because features do get added often, especially on the scale of projects like ICU4X where we have a large number of crates. I think the intent of the key...

You're welcome to experiment with this and provide a patch.

I'm going to block this on figuring out the exact solution for https://github.com/Manishearth/elsa/issues/48 since that may change a bunch of the relevant internals here and I really don't want to...

That's going to be most of the important ones, and plus the changes I do there may also affect other types like the BTreeMaps. I don't think it's worth landing...

I think that misses the case where new commits have been pushed since then.

Yeah I'm wondering if we can keep those requirements but perhaps behind a flag.