elsa icon indicating copy to clipboard operation
elsa copied to clipboard

Published 20 hours ago • verified publisher icon Manishearth

feat: implement serde for all the containers

Open aminya opened this issue 10 months ago • 5 comments

aminya avatar Aug 10 '23 03:08 aminya

I'm going to block this on figuring out the exact solution for https://github.com/Manishearth/elsa/issues/48 since that may change a bunch of the relevant internals here and I really don't want to complicate that situation more.

Manishearth avatar Aug 10 '23 14:08 Manishearth

I can revert those affected by #48 until this is fixed https://github.com/Manishearth/elsa/issues/48#issuecomment-1674048753

aminya avatar Aug 10 '23 23:08 aminya

That's going to be most of the important ones, and plus the changes I do there may also affect other types like the BTreeMaps. I don't think it's worth landing this PR with those things removed.

Manishearth avatar Aug 10 '23 23:08 Manishearth

I actually prefer if you merge #62 before this PR as it allows me to test serialization/deserialization back-to-back via assert_eq

aminya avatar Sep 23 '23 08:09 aminya

Waiting for #72 so that I can add the tests for all implementations.

aminya avatar Nov 19 '23 06:11 aminya