Manish Goregaokar

Results 596 comments of Manish Goregaokar

I really _don't_ want us to have to maintain this as a fork :smile:

Instead of doing a merge, we could potentially try a "fresh start" where we _first_ try moving compiletest out of tree, and if that works, release it as a breaking...

Filed rustc side of this issue in https://github.com/rust-lang/rust/issues/82946

@ritchie46 would it be acceptable to make `fast-float` an optional dependency and use _checked_ `from_utf8` as the alternative? This way people can have safe-but-slightly-slower code. Or even a manual impl...

Someone needs to file an issue about it with detail (sorry, IMO that should have happened first), but basically in the process of an unsafe audit we discovered that `fast-float`...

Filed an issue with some detail: https://github.com/aldanor/fast-float-rust/issues/37 Doing a proper safety audit of that code will take much longer and is not really worth it for me, at least.

This is basically `git absorb`, I've wanted that functionality as well

I think a good path forward here would be to make PRs to https://github.com/tummychow/git-absorb to make it possible to use to implement this functionality in git-revise (i.e. git-revise queries git-absorb...

Oh, git absorb sets up fixup commits? Neat! I was under the impression it directly did the rebase