Manish Goregaokar

Results 1329 comments of Manish Goregaokar

Note: I'm not actively working on this right now, and don't really plan to in the near future, if someone wants to figure out how to make the float stuff...

@Lokathor Clippy has different policies from Rust on this, though, and that's _fine_. If anything, Clippy is _more_ liberal about "breaking" code on clippy updates, however we do try and...

@Lokathor Okay, in that case please reread @llogiq's comment that you were pushing back on, because it is explicitly about clippy's choices :smile:

I have comments along a couple axes and for cleanliness I'll post them as separate comments. ## Clippy vs Rust lint level standards So this RFC cites experiences with `clippy`...

Hmm, they're broader than any particular part they anchor on, but sure. My first comment above in particular is not trying to start a discussion, it's trying to provide context....

@ijackson does my proposed alternate design with lint profiles support your use cases? https://github.com/rust-lang/rfcs/pull/3730#discussion_r1859460148

@sffc noted that the ForkByKey provider doesn't implement DataProvider the way we want it to because of specialization, but we could instead use a macro to generate a custom type...

We can also do this in the metacrate, using the registry. Per-formatter baked providers are not strictly necessary.

Yeah, I haven't seen a client need yet, however I have found myself wanting to _suggest_ workflows involving this when suggesting ICU4X to people who are likely to use runtime...

We have the following failing test262 tests: ``` 'built-ins/Temporal/Duration/prototype/add/argument-duration-precision-exact-numerical-values': [FAIL], 'built-ins/Temporal/Duration/prototype/round/out-of-range-when-converting-from-normalized-duration': [FAIL], 'built-ins/Temporal/Duration/prototype/subtract/argument-duration-precision-exact-numerical-values': [FAIL], 'built-ins/Temporal/Duration/prototype/total/precision-exact-mathematical-values-6': [FAIL], 'built-ins/Temporal/Duration/prototype/total/precision-exact-mathematical-values-7': [FAIL], ``` It may be possible to fix them with just https://github.com/boa-dev/temporal/issues/334, but...