Manish Goregaokar comments

Results 1335 comments of


                                            Manish Goregaokar

[launching-pad] Find a home for the Security Response WG

Yes, an ops team makes sense!

[launching-pad] Find a home for the Security Response WG

Yes, this should remain under a cross cutting concerns team.

#[derive(ULE, VarULE)]` could be more useful for simple wrapper types

Yeah I think when I filed this issue it felt small, but for VarULE _specifically_ I don't think it is anymore. (For ULE it's almost always the case that having...

#[derive(ULE, VarULE)]` could be more useful for simple wrapper types

In #5124 we're also discussing finding a way to avoid these derives and using macros instead. Looking at the codebase, I see a bunch of similar but distinct use cases:...

#[derive(ULE, VarULE)]` could be more useful for simple wrapper types

Moving that discussion to https://github.com/unicode-org/icu4x/issues/5127

Update to new ComputeNudgeWindow spec text

This now passes tests, but I'm not entirely sure of the impl

Update to new ComputeNudgeWindow spec text

This fails other tests (due to hitting assertions, I think) ``` === test262/built-ins/Temporal/PlainDate/prototype/since/roundingincrement === --- stdout --- test/test262/data/test/built-ins/Temporal/PlainDate/prototype/since/roundingincrement.js:15: Error: Temporal error: Internal error: . later.since(earlier, { smallestUnit: "years", roundingIncrement: 4,...