Manish Goregaokar

Results 1311 comments of Manish Goregaokar

Full list of low hanging fruit that comes to my mind: - Adding macro solutions to https://github.com/unicode-org/icu4x/issues/2310 , #2778 to reduce the bulk of our `derive(ULE)` - Potentially getting rid...

> If the recipient really wants to audit everything themselves, then generated code on crates.io is worse for auditability. However, if the recipient uses cargo-vet and trusts that the core...

> IMO that's just silly -- whether you publish code with derive macros that then goes to expand to `unsafe` or have code generating code with `unsafe` in it pre-publish...

> Still feels like there's a way out here where you could mark generated code with some tokens that make it obvious where/how the code was generated and this would...

I think for the purpose of the immediate rust-url issue this is resolved as much as we intend to. I don't think we currently have anything actionable here. There are...

> no, this breaks type inference for everyone else Important to note, this breaks type inference in an intractable way. A property we currently have is that `let dtf =...

> A non-local time should always be accompanied by a date, because often it is on a different day Things can be "daily at 10 Pacific". This is definitely something...

Start 11:08 - @sffc I think we should have it; doesn't necesarily need to be in 2.0 itself - @robertbastian If we need it for formatting seems fine, but I...

We've moved this out of 2.0-stretch, but if @robertbastian is looking for stuff to work on, this would still be quite appreciated if it sneaks in.