Manish Goregaokar

Results 1204 comments of Manish Goregaokar

> Having to reason about this in the middle of a TokenStream is worse for everyone. I generally agree, but with the tokenstream at least the invariants are all in...

I don't understand what is and isn't generated there. I'm in favor of a `databake::unsafe_impl_from_parts!(Type, from => to)` macro: the invariants are easy to specify for that.

> Unless you think the word `unsafe` in `databake::unsafe_impl_from_parts!` is sufficient? Yes, that's standard macro naming practice. I wish there were a better way to do unsafe macros, but it's...

Do not rely on clippy lints triggering within macros; they are often explicitly disabled within macros depending on the lint