Mahmoud Ahmed comments

Results 26 comments of


                                            Mahmoud Ahmed

Images read differently on ubuntu vs windows

:point_up: @maelle. Thanks.

`ghi comment -amend` doesn't work

Test message, edited.

`ghi comment -amend` doesn't work

Hi @alphaCTzo7G. I think the proper way to use the option `--amend` with `ghi comment` command is to place the text right after the option and before the issue number....

Can't load library

Hi @cwilso6 This error is likely caused by multiple installations of the same package. You may try `remove.packages` first and then reinstall `colocr`.

Use column in data table for grouping when column name is passed as string to group_var

The problem with this approach is that the user would have to also specify the column names for the genes of interest. I chose early on to make the main...

Add the option to use less-than-perfect amplification efficiencies

Thanks @richardstoeckl I looked at the code. It is not passing the checks likely because you are using the pipe `%>%` and `dplyr::select` which are not dependencies in the package....

Add the option to use less-than-perfect amplification efficiencies

I think it is reasonable to expect the user to provide the vector of efficiencies that corresponds to the genes in the correct order. We just need to make it...

technical replicates

Hi @abusjahn Thanks for reaching out. `pcr` do not handle technical replicates at the moment. As you mentioned, most people collapse the technical replicates and work with the averages. I...

SEM instead of SD

Hi @lmanchon It is not clear to me how to get the SEM with error propagation as obtained in the package. You could just divide the "error" term by the...

Factor in amplification efficiency

Thanks, @richardstoeckl for reaching out, and sorry for the late reply. I think this approach would work. Would you like to submit a pull request? I will review the code...