Lucio Franco
Lucio Franco
Hi sorry for the delay on this, I started to review this but I am going to need some time to really dive deep on this since what you are...
cc @danburkert @neoeinstein
I wonder if encode/decode should become free fn and that would allow decode to be obj safe? Splitting the generics is an idea though not sure how useful in practice.
Yeah, I also got to the same conclusion w/ Unpin. Maybe its something to do with https://docs.rs/aws-smithy-http/latest/src/aws_smithy_http/byte_stream.rs.html#501 copy_to_bytes?
Nice! Just want to let you know I see this but I have a bunch of high priority things on my plate atm so may take me a bit to...
@djc I feel like `quic` is a bit unique here compared to TCP in general. Not sure, how quic fits into the `AsyncRead + AsyncWrite` interface?
I think this is a really interesting and good idea, though the API design having it be a poll fn that doesn't return `Poll` seems really awkward.
> `Body` consumers can use this method to check if the body has entered an error state even when the consumer is not yet ready to try to read the...
Why not let users downcast it? If http will also 1.0 I don't see the issue in that? Otherwise, I agree with what you said.
This change makes sense, we need to bundle it with other breaking changes though.