Lucio Franco comments

Results 524 comments of


                                            Lucio Franco

prost-types: fix tests without default features

I think you need to merge from master

Deriving Message gives warning about snake_case

This seems like its been fixed?

Build fails: thread 'main' panicked at 'index out of bounds: the len is 0 but the index is 0'

@zelenij we could probably add a nice error message.

Use of `--include_imports` option should be optional

@kriswuollett I wonder if we could just add another fds option on config that unsets this option when set?

Use of `--include_imports` option should be optional

@kriswuollett you can just generate your own fds via protoc or something like protox and pass that to prost should handle your use case?

Custom { kind: PermissionDenied, error: "failed to invoke protoc (hint: https://docs.rs/prost-build/#sourcing-protoc): (path: \"F:\\\\.protoc\\\\bin\"): 拒绝访问。 (os error 5)" }' #44

Can you invoke `protoc` by itself?

Custom { kind: PermissionDenied, error: "failed to invoke protoc (hint: https://docs.rs/prost-build/#sourcing-protoc): (path: \"F:\\\\.protoc\\\\bin\"): 拒绝访问。 (os error 5)" }' #44

I am not sure then, I would need to find a way to reproduce this. One option is to start using `protox` as it is a pure rust implementation and...

Unseal BytesAdapter

Could we potentially just leverage `BufMut` and remove our own trait?

Optimize varint encoding

I am not seeing the same improvements on my laptop ``` varint/small/encode time: [254.51 ns 255.08 ns 255.78 ns] change: [+4.9943% +5.3430% +5.6646%] (p = 0.00 < 0.05) Performance has...

Optimize varint encoding

Could you explain more what system you ran those benchmarks on?