Lucio Franco
Lucio Franco
Yeah, I think we can just do this https://docs.rs/prost-build/latest/prost_build/struct.Config.html#method.disable_comments but for debug impl? Should be pretty easy to add and isn't a breaking change.
Ah you're right, maybe we can have a attribute option that sets no debug and then that can be enabled via prost-build.
I have no come up with a plan yet but will need to figure this out for tonic as well and in addition will need to figure out what else...
Hi @0xAlcibiades sorry about the delay. I don't have time right now to come up with a fix but I can review a PR if someone is interested in picking...
Yeah this needs a PR to fix this. thanks for catching it.
I will need to think about this change, in the meantime I think bumping the msrv is okay.
Can you provide some motivation for this change
I think this would be an interesting idea, but before we claim this we should write a test suite that verifies this and keeps track of this. If you're willing...
@andrewhickman i am hestitant to expose a lot of this right now since I can't even keep up with this load. If you're interested in helping out maintain prost then...
@danburkert if you have the time can you take a look