prost icon indicating copy to clipboard operation
prost copied to clipboard

Published 20 hours ago • verified publisher icon tokio-rs

Implement `Arc`, `Box` wrapper of message fields.

Open ldm0 opened this issue 2 years ago • 12 comments

Closes #429 ~~Marked as draft since tests haven't been added.(Go to bed now :-P)~~

ldm0 avatar Aug 13 '22 20:08 ldm0

Mostly done, add more tests later.

ldm0 avatar Oct 18 '22 12:10 ldm0

Nice! Just want to let you know I see this but I have a bunch of high priority things on my plate atm so may take me a bit to get to a review of this.

LucioFranco avatar Oct 18 '22 15:10 LucioFranco

How is this working out? It's sad that I have to call many Vec::clone() to send a message with repeated fields to thousands of clients 😥. I'm hoping this PR will solve my problem.

80ROkWOC4j avatar Mar 26 '24 03:03 80ROkWOC4j

I just want to second this. Having Arc would be sweet, as memory consumption on some structs is reaching relative high levels in quickwit

PSeitz avatar Apr 18 '24 14:04 PSeitz