Lucio Franco comments

Results 524 comments of


                                            Lucio Franco

transport: Support applying connect timeout to custom connectors

I probably mean't custom connector xD

When I'm using tonic_build with slight complex structure, the code generator display weird errors

Yeah, we could provide some better docs around this for sure.

When I'm using tonic_build with slight complex structure, the code generator display weird errors

I would accept PRs fixing docs 😄

make codec::decode::Streaming a trait for easier testability

I don't know if moving stream to a trait like this is the correct solution. I think adding a way to pass in complete messages to the stream struct would...

make codec::decode::Streaming a trait for easier testability

Yeah, I agree there should be an easier way. Let me take a think here.

improper error handling with from h2 reason::cancel -> tonic::code::unkown

In this case you will need to downcast to the timeout error since you added that layer it looks like and tonic doesn't directly map those timeout errors on the...

improper error handling with from h2 reason::cancel -> tonic::code::unkown

@lyang24 did you ever get a chance to get a repro?

Client always generates content-type: application/grpc & server not recognizing a combined content-type header

So historically, grpc-go only worked with `application/grpc` and if you used `+proto` etc things just broke. I found this out the hard way when working on the `gcp` example. For...

Update helloworld-tutorial to include protos split over multiple files

Yeah this seems like something we could show at the end as an extra maybe?

Usage of tokio::fs/io in client stream handler function seems to prohibit client stream error propagation

Do you by chance have a simple reproduction of the issue?