Lucio Franco

Results 524 comments of Lucio Franco

are you calling this `tonic::include_file_descriptor_set!("test")` in the same crate that you have the descriptor set in?

Once we fix the conflicts lets merge :+1:

@wqshr12345 is the client cancelling the request halfway through? If so tonic will drop the task when the client does that.

@andrewhickman would you be interested in starting that work? I think id like to get a release out today but we can add these in both prost/tonic in a non-breaking...

You need to use https://docs.rs/tonic/latest/tonic/transport/channel/struct.Endpoint.html#method.tls_config to enable the tls negotiation iirc

Hi sorry for the delay. I think the comments make sense but I am taking a small break for the next few weeks so the progress has been slow here.

@martinabeleda seems like there are some failures around feature flags in CI.

Yeah, that seems like a bug here https://github.com/hyperium/tonic/blob/master/tonic/src/client/grpc.rs#L380 and maybe also on the server side. I would accept a PR that fixed this.

Seems like CI is failing with missing docs

> This has the drawback that in order to maintain present behaviour, the flag is a 'disable' type flag and not an enable flag. Could you explain what you mean...