Cristian Le

Results 1273 comments of Cristian Le

Was confused why this was not a merge conflict. You should overwrite the `.github/renovate.json`, but I don't know if renovatebot will continue to update the top-level comment with the new...

> * do we need both `.github/renovate.json` and `renovate.json`? No, only one is authoritative. This PR is mostly to reconfigure it again and tweak some settings. Unfortunately, what each settings...

My vote is to replace the contents in `.github/renovate.json`. But actually I got notified of [this work](https://github.com/renovatebot/renovate/pull/34696). @martinhoyer can we put this one on hold until that one is merged...

In that case how about ``` /packit pull-from-upstream --rebase-with-this-pr ``` Wordy but I think it would best describe what the behavior is meant to be, i.e. - Either - checkout...

So @skycastlelily what do you think about making this its own lint rule like ```python class Plan: def lint_unique_names(self) -> LinterReturn: """ P0XX: phases must have valid data """ passed...

> I think it's pretty, actually that is the solution I was thinking to take before I sent this mr, however it does not work, because normalize* functions will not...

Oh, that's rather divergent from the `json-schema`: https://github.com/fedora-infra/anitya-messages/blob/7754ca6832fd773e9d8e622024743af0483cec9d/anitya_schema/project_messages.py#L692-L729 Indeed it is similar, but having the distinction between the 3 variants will be helpful because it is unclear if latest version...

Sure, in essence my current code does: ```python class MyObjDirective(SphinxDirective) has_content = False required_arguments = 1 def run(self) -> list[Node]: name = self.arguments[0] title = name.split("/")[-1] # Would like to...

> > LGTM. Please also patch `tmt.steps.execute.Execute.create_results` > > Why so? Ah, I thought it was using a guest instance, but yeah those are just strings, nvm it.

/packit retest-failed