Cristian Le

Results 1273 comments of Cristian Le

> I briefly looked into the code and I am thinking if it wouldn't be more fitting to have the logic for checking this in [this method](https://github.com/packit/packit-service/blob/e24583035cf6abb96559ee7586bd0127351aaba2/packit_service/worker/jobs.py#L849), which would mean...

> @LecrisUT can you elaborate more on what you are suggesting? I agree the code I linked could be refactored, but it is something different than the Checker's logic, as...

I can try to make some progress this week. One question to be answered is https://github.com/packit/packit-service/pull/2780#discussion_r2111302592. There are a few ways to approach this: - Use `ogr` and navigate to...

Where do I get the push event? Otherwise, it seems we still need the ogr changes for the pull-request trigger, the webhook does not have equivalent data.

> Nice work. It looks good to me so far. Do you think you'll be able to make progress with this soon? Yes, it's just one blocker to figure out...

> * Is this only about actions or with configs in general? > > * E.g. With actions usually comes dependencies. > * SIGs might also have a particular agreement...

My main concern is if `yaml-rust2` will get dependencies updated in time. So far neither of them have a dependabot/renovatebot setup. If they plan to keep them both updated, then...

I thought that one had a required setup of labels and such. But yeah, it could work. I'll make a few PRs for those

I think still relevant to add. @FrNecas still willing to move this forward, or should someone else take over?