tmt icon indicating copy to clipboard operation
tmt copied to clipboard
verified publisher icon teemtee

Configure Renovate - abandoned

Open renovate[bot] opened this issue 8 months ago • 7 comments

Welcome to Renovate! This is an onboarding PR to help you understand and configure settings before regular Pull Requests begin.

🚦 To activate Renovate, merge this Pull Request. To disable Renovate, simply close this Pull Request unmerged.

Detected Package Files

  • containers/Containerfile.full (dockerfile)
  • containers/Containerfile.mini (dockerfile)
  • containers/alpine/Containerfile (dockerfile)
  • containers/alpine/Containerfile.upstream (dockerfile)
  • containers/centos/7/Containerfile (dockerfile)
  • containers/centos/7/Containerfile.upstream (dockerfile)
  • containers/centos/stream10/Containerfile (dockerfile)
  • containers/centos/stream10/Containerfile.upstream (dockerfile)
  • containers/centos/stream9/Containerfile (dockerfile)
  • containers/centos/stream9/Containerfile.upstream (dockerfile)
  • containers/debian/12.7/Containerfile.upstream (dockerfile)
  • containers/fedora/40/Containerfile (dockerfile)
  • containers/fedora/40/Containerfile.unprivileged (dockerfile)
  • containers/fedora/40/Containerfile.upstream (dockerfile)
  • containers/fedora/41/Containerfile (dockerfile)
  • containers/fedora/41/Containerfile.unprivileged (dockerfile)
  • containers/fedora/41/Containerfile.upstream (dockerfile)
  • containers/fedora/coreos/Containerfile (dockerfile)
  • containers/fedora/coreos/ostree/Containerfile (dockerfile)
  • containers/fedora/latest/Containerfile (dockerfile)
  • containers/fedora/latest/Containerfile.unprivileged (dockerfile)
  • containers/fedora/latest/Containerfile.upstream (dockerfile)
  • containers/fedora/rawhide/Containerfile (dockerfile)
  • containers/fedora/rawhide/Containerfile.unprivileged (dockerfile)
  • containers/fedora/rawhide/Containerfile.upstream (dockerfile)
  • containers/ubi/8/Containerfile.upstream (dockerfile)
  • containers/ubuntu/22.04/Containerfile.upstream (dockerfile)
  • .github/workflows/doc-tests.yml (github-actions)
  • .github/workflows/pre-commit.yml (github-actions)
  • .github/workflows/publish-images.yml (github-actions)
  • .github/workflows/release.yml (github-actions)
  • .github/workflows/shellcheck.yml (github-actions)
  • pyproject.toml (pep621)
  • .pre-commit-config.yaml (pre-commit)

Configuration Summary

Based on the default config's presets, Renovate will:

  • Start dependency updates only once this onboarding PR is merged
  • Hopefully safe environment variables to allow users to configure.
  • Show all Merge Confidence badges for pull requests.
  • Enable Renovate Dependency Dashboard creation.
  • Use semantic commit type fix for dependencies and chore for all others if semantic commits are in use.
  • Ignore node_modules, bower_components, vendor and various test/tests (except for nuget) directories.
  • Group known monorepo packages together.
  • Use curated list of recommended non-monorepo package groupings.
  • Apply crowd-sourced package replacement rules.
  • Apply crowd-sourced workarounds for known problems with packages.
  • Weekly schedule on early Monday mornings (before 4 AM).
  • Enable the pre-commit manager.
  • If Renovate detects semantic commits, it will use semantic commit type chore for all commits.
  • Run Renovate on following schedule: * 0-3 * * 1

🔡 Do you want to change how Renovate upgrades your dependencies? Add your custom config to renovate.json in this branch. Renovate will update the Pull Request description the next time it runs.

What to Expect

With your current configuration, Renovate will create 15 Pull Requests:

chore(deps): update pre-commit hook charliermarsh/ruff-pre-commit to v0.11.7
  • Schedule: ["* 0-3 * * 1"]
  • Branch name: renovate/charliermarsh-ruff-pre-commit-0.x
  • Merge into: main
  • Upgrade charliermarsh/ruff-pre-commit to v0.11.7
chore(deps): update pre-commit hook robertcraigie/pyright-python to v1.1.400
  • Schedule: ["* 0-3 * * 1"]
  • Branch name: renovate/robertcraigie-pyright-python-1.x
  • Merge into: main
  • Upgrade RobertCraigie/pyright-python to v1.1.400
chore(deps): update pre-commit/action action to v3.0.1
  • Schedule: ["* 0-3 * * 1"]
  • Branch name: renovate/pre-commit-action-3.x
  • Merge into: main
  • Upgrade pre-commit/action to v3.0.1
chore(deps): update dependency python to 3.x
  • Schedule: ["* 0-3 * * 1"]
  • Branch name: renovate/python-3.x
  • Merge into: main
  • Upgrade python to 3.x
chore(deps): update dependency renku-sphinx-theme to v0.5.0
  • Schedule: ["* 0-3 * * 1"]
  • Branch name: renovate/renku-sphinx-theme-0.x
  • Merge into: main
  • Upgrade renku-sphinx-theme to ==0.5.0
chore(deps): update dependency sphinx to v7.4.7
  • Schedule: ["* 0-3 * * 1"]
  • Branch name: renovate/sphinx-7.x
  • Merge into: main
  • Upgrade sphinx to ==7.4.7
chore(deps): update dependency types-requests to
  • Schedule: ["* 0-3 * * 1"]
  • Branch name: renovate/types-requests-2.x
  • Merge into: main
  • Upgrade types-requests to <2.32.0.20250329
chore(deps): update dependency yq to v3.4.3
  • Schedule: ["* 0-3 * * 1"]
  • Branch name: renovate/yq-3.x
  • Merge into: main
  • Upgrade yq to ==3.4.3
chore(deps): update docker.io/library/alpine docker tag to v3.21
  • Schedule: ["* 0-3 * * 1"]
  • Branch name: renovate/docker.io-library-alpine-3.x
  • Merge into: main
  • Upgrade docker.io/library/alpine to 3.21
chore(deps): update docker.io/library/debian docker tag to v12.10
  • Schedule: ["* 0-3 * * 1"]
  • Branch name: renovate/docker.io-library-debian-12.x
  • Merge into: main
  • Upgrade docker.io/library/debian to 12.10
chore(deps): update pre-commit hook ansible-community/ansible-lint to v25.4.0
  • Schedule: ["* 0-3 * * 1"]
  • Branch name: renovate/ansible-community-ansible-lint-25.x
  • Merge into: main
  • Upgrade ansible-community/ansible-lint to v25.4.0
chore(deps): update pre-commit hook teemtee/tmt to v1.47.0
  • Schedule: ["* 0-3 * * 1"]
  • Branch name: renovate/teemtee-tmt-1.x
  • Merge into: main
  • Upgrade teemtee/tmt to 1.47.0
chore(deps): update dependency sphinx to v8
  • Schedule: ["* 0-3 * * 1"]
  • Branch name: renovate/sphinx-8.x
  • Merge into: main
  • Upgrade sphinx to ==8.2.3
chore(deps): update docker.io/library/ubuntu docker tag to v24
  • Schedule: ["* 0-3 * * 1"]
  • Branch name: renovate/docker.io-library-ubuntu-24.x
  • Merge into: main
  • Upgrade docker.io/library/ubuntu to 24.04
chore(deps): update redhat-plumbers-in-action/differential-shellcheck action to v5

🚸 Branch creation will be limited to maximum 2 per hour, so it doesn't swamp any CI resources or overwhelm the project. See docs for prhourlylimit for details.

❓ Got questions? Check out Renovate's Docs, particularly the Getting Started section. If you need any further assistance then you can also request help here.

This PR was generated by Mend Renovate. View the repository job log.

renovate[bot] avatar Apr 22 '25 11:04 renovate[bot]

Is this a duplicate of #2923?

psss avatar Apr 22 '25 11:04 psss

Yes, it's a duplicate, but you can use this and the top-level comment here to play around with the renovate.json

LecrisUT avatar Apr 22 '25 11:04 LecrisUT

This config seems to work as expected as per the top comment update. Let's use it in #2923? Do we want to have it in .github dir? Doesn't seem super github related, but no strong opinions from me.

martinhoyer avatar Apr 22 '25 12:04 martinhoyer

Do we want to have it in .github dir? Doesn't seem super github related, but no strong opinions from me.

The reasoning I've seen for these is that if it's not for something that is run locally, but it is meant for the CI system then it should go in those locations. So .github/workflows, .github/codecov, .github/readthedocs.yaml (although this one does not seem to be supported), .github/dependabot.yaml, .github/renovate.json would fit those categories. .packit, .fmf on the other wand would not fit that category. testing-farm.yaml would probably be in the middle.

LecrisUT avatar Apr 22 '25 12:04 LecrisUT

As discussed on tmt review meeting, we will get in #3662 and #2923 and leave this one to renovate to update once it is in main

thrix avatar Apr 22 '25 13:04 thrix

Autoclosing Skipped

This PR has been flagged for autoclosing. However, it is being skipped due to the branch being already modified. Please close/delete it manually or report a bug if you think this is in error.

renovate[bot] avatar Apr 29 '25 14:04 renovate[bot]

Was confused why this was not a merge conflict. You should overwrite the .github/renovate.json, but I don't know if renovatebot will continue to update the top-level comment with the new configuration.

LecrisUT avatar May 09 '25 12:05 LecrisUT

Was confused why this was not a merge conflict. You should overwrite the .github/renovate.json, but I don't know if renovatebot will continue to update the top-level comment with the new configuration.

The introduction of renovate was quite a mess tbh. I just hope this config can get in soon-ish. @psss is on release duty :)

martinhoyer avatar May 15 '25 17:05 martinhoyer

I tried to read the patch and I realized I already saw something similar.

  • do we need both .github/renovate.json and renovate.json?
  • the "abandoned" note in $SUBJ, that's kind of puzzling when there is a recent discussion about merging this PR. Can the $SUBJ be changed to reflect reality?

happz avatar May 16 '25 08:05 happz 

* do we need both `.github/renovate.json` and `renovate.json`?

No, only one is authoritative. This PR is mostly to reconfigure it again and tweak some settings. Unfortunately, what each settings actually does is a bit of a black box, so I was hoping that we could use the onboarding PR to uncover some of the details.

* the "abandoned" note in $SUBJ, that's kind of puzzling when there is a recent discussion about merging this PR. Can the $SUBJ be changed to reflect reality?

Ah, I've found a relevant documentation: https://docs.renovatebot.com/getting-started/installing-onboarding/#nuke-config-and-re-onboard

Basically to get the onboarding PR again (so that it can show you what it would actually be doing) the files must be deleted and a new PR will be created. Briliant UX :sweat_smile:

Alternatively, this should also work on a fork

LecrisUT avatar May 16 '25 08:05 LecrisUT 

* do we need both `.github/renovate.json` and `renovate.json`?

No, only one is authoritative. This PR is mostly to reconfigure it again and tweak some settings. Unfortunately, what each settings actually does is a bit of a black box, so I was hoping that we could use the onboarding PR to uncover some of the details.

* the "abandoned" note in $SUBJ, that's kind of puzzling when there is a recent discussion about merging this PR. Can the $SUBJ be changed to reflect reality?

Ah, I've found a relevant documentation: https://docs.renovatebot.com/getting-started/installing-onboarding/#nuke-config-and-re-onboard

Basically to get the onboarding PR again (so that it can show you what it would actually be doing) the files must be deleted and a new PR will be created. Briliant UX 😅

Alternatively, this should also work on a fork

I think I forgot one question: are we going to merge this PR, or is it just a testing ground + review we would eventually move into .github/renovate.json (or drop that one and merge renovate.json, as you said, one is good enough).

happz avatar May 16 '25 08:05 happz

My vote is to replace the contents in .github/renovate.json. But actually I got notified of this work. @martinhoyer can we put this one on hold until that one is merged and released, then we have a simpler way of reviewing the changes. I can't judge how far that PR is, but it seems mostly finished.

LecrisUT avatar May 16 '25 09:05 LecrisUT

My vote is to replace the contents in .github/renovate.json.

Ok, now I think I get it, thanks.

happz avatar May 16 '25 11:05 happz

My vote is to replace the contents in .github/renovate.json.

Agreed. Let's use this location for the config.

But actually I got notified of this work. @martinhoyer can we put this one on hold until that one is merged and released, then we have a simpler way of reviewing the changes.

Agreed as well. It would be nice to see what would happen before we enable the bot and the approach outlined in renovatebot/renovate/pull/34696 sounds much better than closing and opening many new pull requests.

With your current configuration, Renovate will create 15 Pull Requests:

This does not seems reasonable. Each pre-commit hook update in a separate pull request. Seems that our initial config was no respected. One more thing: Documentation states:

You can edit your Renovate configuration within the renovate/configure branch and Renovate will keep updating the description in the PR to match, so you can work on the config until you're satisfied with the results.

So... this sounds like the description of the pull request should be updated already now. Let's see what happens if we enable the grouping.

psss avatar May 20 '25 20:05 psss

Ok, so it seems the bot now adds back abandoned into to title because it already sees we have the configuration set. Let's try to wait a bit until the interactive reconfigure is implemented. Putting to backlog for now.

psss avatar May 21 '25 07:05 psss

Ok, so it seems the bot now adds back abandoned into to title because it already sees we have the configuration set. Let's try to wait a bit until the interactive reconfigure is implemented. Putting to backlog for now.

we can use renovate/reconfigure branch for this purpose.

Closing in favour of #3775

martinhoyer avatar May 27 '25 09:05 martinhoyer