packit-service icon indicating copy to clipboard operation
packit-service copied to clipboard

Add a flag for `/packit pull-from-upstream` to include files or commit from the `--with-pr-config`

Open LecrisUT opened this issue 11 months ago • 2 comments

Description

Example case is in rust2rpm, sometimes we want to make some changes to the rust2rpm.toml and then rerun it with those changed files/manually created patches etc. In this case I would want to run something like

/packit pull-from-upstream --with-pr-config --sync-files

In this case it should also imply that the .packit.yaml file is being synced.

Benefit

Normally I would do this in fbrnch if I am already editing this, but the former does not create PRs. packit would offer an alternative to this workflow, which could improve with side-tag management.

Importance

No response

What is the impacted category (job)?

Fedora release automation

Workaround

  • [x] There is an existing workaround that can be used until this feature is implemented.

Participation

  • [x] I am willing to submit a pull request for this issue. (Packit team is happy to help!)

LecrisUT avatar Mar 21 '25 10:03 LecrisUT

As we discussed on the stand up, it would make sense to either have an option for syncing the files, or even redoing the switch so it would be something like --merge instead of combination of 2 switches, which would be more natural in the terms of expected behavior.

mfocko avatar Mar 25 '25 14:03 mfocko

In that case how about

/packit pull-from-upstream --rebase-with-this-pr

Wordy but I think it would best describe what the behavior is meant to be, i.e.

  • Either
    • checkout the current PR where the comment was made
    • checkout the target branch, rebase the commits from the current PR
  • Do the rest of the pull-from-upstream logic
  • Create a new PR

LecrisUT avatar Mar 25 '25 14:03 LecrisUT