Cristian Le

Results 1273 comments of Cristian Le

A wrapper around `Path` would be ok I guess, but we would probably need to generalize it for #2946 to add a `MultiplexedPath` variant also.

Seems reasonable and no longer blocked

~~Indeed, I've checked the failure and it's about `file(RELATIVE_PATH)`, iirc `cmake_path(RELATIVE_TO)` resolves the path with different roots, but it needs `CMake 3.20` there. I will see what I can come...

> > cmake --install --prefix > > in that case, we'd want sysconfdir to refer to what was specified as `CMAKE_INSTALL_PREFIX` at configure time, not the prefix at install time....

One thing that I've caught that may be a topic for a different PR, are the `GR_*_DIR` variables in the `Config.cmake` meant to be as the original paths given, or...

Cool, can you manually check the `.pc` file works well and/or any dependent packages just to be sure the devel files are fine?

> ¹ The shell completions don't seem to get installed. I suspect that might be a small thing to fix. @LecrisUT would you be able to address that? `GR_*_COMPLETIONS_DIR` don't...

> Something I just noticed now, doing a `ninja install` from a build directory that I just previously ran `ninja` from: Let me rephrase this to see if I understand...

Agreed. If the platforms need this change, they can either cherry-pick it (maybe easier said then done), or request a backport then. There are non-trivial changes in the handling of...