Sirui Mu
Sirui Mu
Rebased onto the latest `main`.
> Not sure how easy this is (or if it's relevant to this PR), but is it possible to get CIR output to have the syntax highlighting as MLIR has...
@OfekShilon Thanks for your review and approval! > We'd appreciate if you'd be available for potential fixes if any issues arise after deployment. I'll follow up on this as the...
The crash dump should be irrelevant of the potential parser bug. I believe this is due to a bug in the implementation of `CIRCallOpLowering` in the MLIR lowering path: https://github.com/llvm/clangir/blob/80e1a10002fce76d0880ef15ff8f481dcad626c1/clang/lib/CIR/Lowering/ThroughMLIR/LowerCIRToMLIR.cpp#L94-L104...
Opened a PR #728 for resolving the crash dump. The parser bug is not resolved.
The direct motivation for this new pass is the proper CallConvLowering of the `!cir.method` type. Currently, this type is lowered during LLVM lowering, which is too late to achieve a...
Sorry for the delay here, I finally got the bandwidth to update this PR. The primary goal of this PR is to introduce the cir-abi-lowering pass which performs ABI lowering...
> I feel it's a bit confusing to have both cir-abi-lowering and cir-call-conv-lowering being distinct passes. Can we merge cir-call-conv-lowering into the former while keeping a switch to enable/disable the...
Rebased.
The [`GotoSolver` pass](https://github.com/llvm/clangir/blob/main/clang/lib/CIR/Dialect/Transforms/GotoSolver.cpp) is quite simple now and does not consider cases like this. I can think of two possible ways to fix this: 1. Update the `GotoSolver` pass and...