Sirui Mu comments

Results 108 comments of


                                            Sirui Mu

[CIR][CIRGen] Improve switch support for unrecheable code

Since `switch` statements are more or less like a syntax sugar for `goto`, we may learn some ideas from the way `goto` is implemented in CIR: #508 .

Miss destruction in switch statements

This is a variant of #348 .

Module verification error of switch statements

> do we have some methods to print more information (e.g. the illegal cir body)? Try `-Xclang -clangir-disable-verifier -Xclang -clangir-disable-passes`

Documents for using CIR will be helpful

> Is CIR ready to compile real world workloads? Actually clangir fails to compile the most trivial C++20 coroutine example I could make, see https://godbolt.org/z/36K7WE4n1. Besides, clangir is also missing...

[CIR][Lowering] Add the concept of simple lowering and use it to implement FP intrincis

This is an awesome feature! This is not a blocker for the PR, just some ideas for further development. This feature may be generalized in the future to declare lowering...

[CIR][Lowering] Add the concept of simple lowering and use it to implement FP intrincis

Any progress on this PR?

[CIR][Lowering] Add the concept of simple lowering and use it to implement FP intrincis

Let me work on this PR.

Possible bug in OpenMP implementation

The second line of the CIR error output gives the position of the error: https://github.com/llvm/clangir/blob/b26f21d9d7d5f2a614d77bfb47a62d18f9344b6e/clang/lib/CIR/CodeGen/CIRGenerator.cpp#L162-L165 Basically this code checks whether we have `-fopenmp` flag in the command line. If the...

How should cir.base_class_addr work

As a side note to this thread, `cir.base_class_addr` is not the only operation who is interested in the conversion path. Another operation also interested in this information is the conversion...

How should cir.base_class_addr work

> @Lancern, you mentioned handling the conversion between member pointers. At least for simple cases like https://godbolt.org/z/45oKh3584, the AST contains a derived-to-base cast before the member pointer dereference, so we...