Sirui Mu
Sirui Mu
Rebased onto the latest `main` and updated this PR according to the latest reviews: - This PR now only deals with the CIRGen of the two new floating point types...
@bcardosolopes Hi Bruno, thanks for your review! Let me explain in more details about why I'm not following the skeleton here. The original clang CodeGen divide expressions into three categories...
> How about you add a FIXME(cir): unlike traditional CodeGen, this shares common code with ScalarExprEmitter to every method that is the same between ComplexExprEmitter and ScalarExprEmitter, so that when...
Rebased onto the latest `main`, but not yet started to work on the reviews.
@bcardosolopes Hi Bruno, I have updated the implementation so that it now follows the upstream skeleton.
Rebased onto the latest `main`.
@bcardosolopes Hi Bruno, I believe this PR is now ready for another round of review. I decide to keep this PR simpler (but the size of the PR is still...
> After looking the PR, I'm not sure we need #cir.imag, it should just be an int or fp attribute directly. > I prefer keeping the #cir.complex to be used...
Rebased onto the latest `main`.
I agree that `#cir.imag` looks inconsistent and not promising. Removed it from this PR, and now imaginary literals such as `1i` is lowered to three ops: two `cir.const` and one...