Sirui Mu
Sirui Mu
This use case is perfectly valid. However IMO implementing `Serialize` and `Deserialize` directly for formatters, sinks and loggers is not a proper way to achieve this. As I said earlier,...
Take formatters as an example, I propose the following interface. Note that all names are not well-considered and are subject to change. First, we add a new trait `SerializableFormatter` that...
How to support custom sinks and formatters? `Registry` does not know their types when loading from configuration files.
LGTM, but the interface design needs to be discussed further. Maybe we can open a draft PR and discuss there?
LGTM, but a small problem on naming convention: what about `lower-letter` rather than `lower_letter`? `Cargo.toml` uses the former.
> So it looks like this now, what do you think? Maybe change `logger` to plural and renaming `logger` to `loggers`? ```toml [loggers.default] # ... [loggers.network] # ... [loggers."gui,unnamed,*"] #...
> Aside from my comments, I may want to wait to merge this until #143 is merged since that's a big change and there would be conflicts. > > @Lancern...
> Ideally, we would expose actual Rust enums in the high-level bindings. Actually, I tried this at the beginning when writing the second commit. However, I quickly ran into problems....
I've updated some source code documentation to reflect the new architecture tag. However, I don't add a systematic overview or tutorial about the architecture tag as I'm not sure whether...
Rebased onto the latest `main`.