Sirui Mu
Sirui Mu
The reason I feel a bit strange is that if you give your user a `&mut PathBuf` in the hook, it strongly expresses the intent that the hook exists _solely_...
> So the current signatures of the event handlers will be > [...] > Is it right? What's the purpose of the `&mut File` parameter? This would allow the user...
Nice work. But I believe we need further discussion on this to avoid any potential security vulnerabilities. There are just too many severe security vulnerabilities in logging libraries. While it...
Well, custom pattern support itself is not the root cause of the security problem. The whole point is, we can provide custom pattern support, provided that **the set of custom...
> Or maybe it would be better to just implement a new `runtime_pattern!` macro? The only difference with the `pattern!` macro for user is that the first parameter only accepts...
I quickly go through the code in this PR and I found it a good starting point for implementing the `runtime_pattern!` macro. So I'm going to push new commits directly...
I have added the `runtime_pattern` macro. I found that I have to implement it as a procedural macro in the `spdlog_macros` crate because the normal macro by example cannot match...
Now the feature should be completed. Seems that I cannot request a review from the PR author through GitHub, so have a review @SpriteOvO .
@SpriteOvO I'll review it as soon as I get some free time before this weekend!
What's the use case? It sounds a little strange to serialize a logger / formatter / sink since these concepts are abstractions for behaviors rather than data.