Ladislav Thon

Results 347 comments of Ladislav Thon

retest this please

Funny that "Linux: Uberjar" passed :-)

Specifying dependencies in the manifest or in `jboss-deployment-structure.xml` sounds like the right way to do this. The correct dependency names are `org.jboss.as.controller-client` and `org.jboss.as.cli`.

It should probably declare `throws Exception`.

The newly created SSL options (see #105) are also affected.

There's also `OnlineManagementClientImpl.apply` that catches `InterruptedException` and throws a different one. This needs careful examination, if the interruption status could possibly be lost in `AutomaticErrorHandlingForCommands`.

If at all possible, old methods that accept millis should be kept and deprecated, while new methods should be added. That way, it could be done before 2.0. But I'm...

I think I spoke with @olukas about that. There might be other people who contributed commands with missing version checks in offline command. I will need to review that.