creaper icon indicating copy to clipboard operation
creaper copied to clipboard

timeouts in OnlineOptions are in millis

Open Ladicek opened this issue 9 years ago • 1 comments

For historical reasons, timeouts in the OnlineOptions class are expected to be provided in milliseconds. Everywhere else (Administration etc.), we use seconds, as that is much more human-friendly.

We should change the OnlineOptions class to accept seconds as well. This would of course be backwards incompatible, so can only be done in 2.0.

Ladicek avatar Oct 05 '16 12:10 Ladicek

If at all possible, old methods that accept millis should be kept and deprecated, while new methods should be added. That way, it could be done before 2.0. But I'm not sure if it's feasible, so for now, I'm keeping the 2.0.0 milestone.

Ladicek avatar Oct 05 '16 12:10 Ladicek