Ladislav Thon

Results 352 comments of Ladislav Thon

Good point! Let me figure out some tests for this.

Added tests. Thanks for insisting on it, I actually discovered a few more subtle bugs -- most importantly, the JSON serialization/deserialization used to get/set the `endpoints` list multiple times, due...

Code LGTM, though it doesn't feel right to special case this particular command. But I don't have a better suggestion at the moment :-)

Oh I totally agree this should work out of the box, without reaching for any special API. We will need to do something similar to properly support Redis transactions in...

When I mentioned transactions, I was thinking of something like this: https://github.com/quarkusio/quarkus/issues/32361#issuecomment-1759586485

I don't know why CI fails, it passed just fine in a PR of mine. @MichaelKubovic could you please rebase? That might help.

You don't need to add an extra commit, you can just amend the commit on top with no changes -- that will change the commit date, which is enough. But...

LGTM. Backport to `4.x` should be OK, thanks!

I'm just thinking, should we special-case some other `SCRIPT ...` command as well? Looking at https://redis.io/commands/?name=script, maybe `SCRIPT FLUSH` would deserve similar treatment to `SCRIPT LOAD`. I'm not sure about...

The `RedisCluster` API added in #466 / #467 allows executing arbitrary commands against all nodes / all master nodes.