Ladislav Thon
Ladislav Thon
I wish I noticed this issue sooner, I would have used the `protocol` param instead of adding an extra method in #422. Oh well. Maybe we can do both? :shrug:
I believe this is exactly what I found in this commit: https://github.com/Ladicek/vertx-redis-client/commit/0dffca4b6907073bdb2ff1ede513df2b9ac194e8 Once the metrics/tracing work is merged, assuming the commit is kept, this would be fixed.
This was fixed in #392 / #398, so the correct milestone here is 4.4.5. Fixed.
This seems related to https://github.com/quarkusio/quarkus/issues/36853, but unfortunately adds no detail that could help diagnose the problem. [This](https://github.com/quarkusio/quarkus/issues/36853#issuecomment-1822920580) is everything I was able to deduce from the error message.
I don't feel qualified to review the caching code, but it seems like the 2 concurrent maps are assumed to be synchronized (_not_ the Java language `synchronized` keyword), even though...
@craig-day OK, that seems like a valid decision, but I guess it should be documented then?
I guess this also applies to the dependency on Interceptors (which probably doesn't need to be there, since the dependency on CDI is transitive).
> CDI lite has a lot of pitfalls in the way it is designed I certainly hope I learn more about them. > and consumers/end users can't rely on any...
> > The only thing that's actually new in CDI 4.0 is the built compatible extension API. Are you suggesting to make that optional? > I'm game -- I don't...
> > Except they are not parallel. One is a strict subset of the other. > > Not really, both can work without the other so they are parallel/transversal. They...