Lloyd Fournier
Lloyd Fournier
hey @notmandatory. What do you think about the approach of just putting the the data in actual tables rather than serializing it in some blob? For reference the tables we'd...
> > hey @notmandatory. What do you think about the approach of just putting the the data in actual tables rather than serializing it in some blob? > > It's...
Note `is_mine` just takes a `&Script`. You probably want the keychain and dervation index. We have a method for that called `derivation_of_spk` so this can be fixed by just updating...
`which_keychain_derived(&self, &Script)`
Is there actually anything to do here. What's wrong with `derivation_of_spk`?
Another bug is that the fee of the replacement tx doesn't satisfy RBF rule 4 (the abs fee is actually lower than the original). This looks like a severe problem....
How does this line even compile: https://github.com/bitcoindevkit/bdk/blob/7aca88474ac241bc0938ff989026463bdaf8f3ab/crates/chain/tests/test_tx_graph.rs#L97 If `unconf_anchor` isn't even an `Anchor` how can you pass it to `insert_anchor`!?!?!?
starting work on this will need to wait until #1203 is merged.
IMO the problem (1) mentioned above by @evanlinjin is minor. It's little concern to users but it would be nice to remove this convoluted logic. I presume he was just...
> Using `Arc` does not solve all the copying problems What copying problems does it not solve? > To make the cache useful, we need a map of Txid ->...