Lloyd Fournier

Results 280 comments of Lloyd Fournier

> When using create_tx does it make sense to have Some(Transaction) always returned so its easy to calculate size? Even if you did that tx doesn't have the correct weight...

> The max satisfaction weight from the descriptor would give you that, right? If all the inputs are yours and you know which input had which descriptor. But in general...

@thunderbiscuit I think you wan to know the feerate before you sign it so you know what you are actually signing. Having those methods on PSBTs seems useful but doesn't...

As I mentioned on the call I think setting a conservative MSRV is a good long term goal but I wouldn't fix it now. It takes time and effort to...

Note that rust development team recommend [at least 1.52.1](https://blog.rust-lang.org/2021/05/10/Rust-1.52.1.html) due to incremental compilation bugs in previous versions. [edit] whoops I see this was mentioned earlier: https://github.com/bitcoindevkit/bdk/issues/331#issuecomment-821768965

My 2c on your plan: 1. I think it's preferable to say that YMMV with MSRV on non-default features and bump dependencies/testing versions whenever needed. Having a rigid policy will...

Since we started discussing this we've spent a lot of time having our CI break. It feels like it happens every other week. From my perspective the main security concern...

> I've always been very careful bumping the MSRV, but I agree that now it's starting to get very annoying and maybe it's time to relax our policy a little...

So after thinking about it. I recall that @johncantrell97 mentioned that LDK made use of this API which also notified you of which blocks have been disconnected as well as...

> This however only works if the version mentioned in the project `Cargo.toml` file is the same one as the one set in the dependency's manifest. I don't have to...