Lloyd Fournier comments

Results 280 comments of


                                            Lloyd Fournier

Inconsistent checking of RBF rules

I volunteer to try and fix RBF API with `bdk_coin_select`. Don't have an ETA yet.

Inconsistent checking of RBF rules

Sorry ACK I haven't had time to do this work so yes you can push it to 2.0.0. Thanks.

Test to showcase high memory consumption of `batch_script_get_history`

Memory never being freed is an issue no matter what size though. I feel like there is a lot to improve in the way we are using electrum at every...

Improve fee sniping deterrence [BIP326]

@ValuedMammal since lightning doesn't us taproot yet is there a strong motivation for doing this now? I do think the goal of this is admirable and I think implementing it...

Update CI to prevent merging any prints to stdout

I think we should add to ci that: ``` rg 'dbg!|println!' -g '!*tests*' -g '!*examples*' -g '*.rs' crates ``` Should always show up clean

The `TxGraph::missing_heights` implementation is problematic.

First I'll respond inline > The logic of `missing_heights` is explained clearly in this comment: > > ```rust > // Usually, if a height of a tx anchor is missing...

The `TxGraph::missing_heights` implementation is problematic.

> @LLFourn thank you for the response. I think we can still write tests with the `ChangeSet::missing_heights_from` method. Yes. I am objecting to these tests being integration tests that actually...

last_seen is wrong on both electrum and esplora

@evanlinjin API limitations? I think you're just meant to get the `SystemTime::now`. That's what we do in the electrum example why can't the same thing work in esplora?

last_seen is wrong on both electrum and esplora

@evanlinjin I think it does. That's a good point but there's nothing we can do about that here. The `TxGraph` will resolve that.

last_seen is wrong on both electrum and esplora

It's better than it not having `last_seen` at all?