Lloyd Fournier
Lloyd Fournier
It's informational. You can display this to the user in the app. It gives you an ordering on unconfirmed transactions. You can use it to tell when a tx was...
> @evanlinjin I'm curious what you mean by esplora returns conflicting unconfirmed txs. Esplora can return two transactions related to a spk that actually conflict with each other. The replaced...
My personal preference which is slightly different from the rust style guide: I'm fine with `get_` if there is something like a corresponding `insert_`. So `get_tx` feels good because there's...
> I think the docs now correctly describe what the method is doing, but it feels like a bug to me, and the docs now simply describe the bug. Yes...
> I've been trying to think of how to keep `ChangeSet` monotone and I think we should not change the keychain::ChangeSet and instead enforce that descriptors don't change at the...
> Thoughts? So after sleeping on it I have changed my view a little bit. The design above is the most in line with the overall design philosophy and removes...
`&K` is fine to me
> I would assume for the majority of cases, `K` is small (as an identifier) so cloning/copying would be cheaper than working with references. Therefore I prefer not having references...
BTW I had a go at doing an [emoji review](https://github.com/erikthedeveloper/code-review-emoji-guide) with this one. Let me know if it helps.
@notmandatory I don't really have an opinion on this being in any milestone. My opinion is that the main issue is fixing RBF design. Being able to verify a transaction...