Lloyd Fournier

Results 280 comments of Lloyd Fournier

To think about it less you can upper bound an individual candidate's weight by it + all the unconfirmed the parents weight and fees. This will get the right answer...

Yeah this is an old design issue with `Wallet` which tries to pretend the `External` keychain is also `Internal` Keychain when an `Internal` keychain doesn't exist. Do we still want...

This is a good point. I seem to recall that things turned out this way because I didn't even plan on having any keychain data in the database in general...

- What's the need for a trait for this? Aren't you suggesting not storing descriptors and just letting the application provide them when creating the keychain txout index. - I...

post fix concept NACK. I interpret these messages are informational (something to log out). You just need to wait for the block that replaces it which will automatically evict the...

I'm guessing you didn't see my comment above where I question whether we should actually do this. If you think I should make a new issue let me know.

See https://github.com/bitcoindevkit/bdk/pull/1176#issuecomment-1928183948 why I no longer think this is a good idea.

How is `list_chain_txs` returning things as `last_seen` as 0 when @thunderbiscuit didn't even insert a last seen for that tx though.

I think this would make sense in `KeychainTxOutIndex`. Needs #1101. After that you can store a height/hash in there when the descriptor is created.

I think it will map fine to sqlite. My main concern is that this isn't a "pants on fire" problem for us yet. I'm not sure it's worth the API...