Korijn van Golen

Results 390 comments of Korijn van Golen

Actually, perhaps it would be easier to build this into dialite?

Thank you for pinging me, I was not aware of the issue and work to address it in #180. I just took some time to review it carefully. Hope we...

This PR looks great to me, you fixed it the proper way. I can't believe I missed the `setup.py` changes in #162, sorry about that. Regarding @HinTak's feedback: > *...

> Besides the moving files, there are a number of unnecessary(?) code changes bundled too (the `import` statement changes). The problem with this pull in its current form is that...

Ok. So then we can merge this?

I have time aplenty to look at such code but no rights to merge. I have to say I am a bit puzzled as to why you decided to cc...

@rougier would you mind merging this? The pyinstaller hook is missing from the `packages` kwarg in `setup.py`, meaning that the hook is not shipped as a part of the wheels...

I'm okay with any path that results in functional pyinstaller support for freetype-py. So for @rougier that's either merging this PR, or removing the hook entirely in a new PR...

I appreciate the transparency @rokm but for @rougier as a TL;DR I would recommend to merge this PR. :)