~Jhellico

Results 88 comments of ~Jhellico

@yashwanth2307, you need to create PR.

I think we can use `dr_congo` now, as v1 will have ISO 3166 codes anyway.

> I noticed that the following holidays are listed as `not a public holiday` on Wikipedia: Maha Shivaratri, Holi, Ram Navami, Hanuman Jayanti, Palm Sunday, Bula Festival, Hibiscus Carnival/Festival, Friendly...

It seems logical to do the same for [Aruba](https://www.iso.org/obp/ui/en/#iso:code:3166:AW).

@Shrot101, it's good start, but it needs to be significantly improved. I advise you to look at latest merged PRs as example (#2583, #2582, #2571, #2562), to better understand requirements...

> Please tell me how to implement a translation file in the locale folder. Do I have to create it for all the languages "da", "en_US", "fo", "is", "no", "sv"....

First of all, you need to merge latest changes from `dev` and resolve conflicts.

> [ ] I've followed the [contributing guidelines](https://github.com/vacanza/holidays/blob/dev/CONTRIBUTING.md) > [ ] I've successfully run make check, all checks and tests are green These statements are not just a formality here.

@samyak003, any progress on this?

> do we want to do "French", "Flemish", "German" Yes, I think, something like that. (There are also VLG / FWB / GER codes, but they are not official and...