python-holidays icon indicating copy to clipboard operation
python-holidays copied to clipboard
verified publisher icon vacanza

Refactor Aruba/Curaçao as NL subdivision

Open arkid15r opened this issue 1 year ago • 3 comments

Feature Request

Description

Make sure Aruba and Curaçao are available as a subdiv of Netherlands (based on https://www.iso.org/obp/ui/en/#iso:code:3166:AW and https://www.iso.org/obp/ui/en/#iso:code:3166:CW).

Related Issues

N/A

Proposed Solution

  • Move the AW and CW holidays logic to NL class.
  • Refactor Aruba logic to be based on NL's subdiv AW
  • Refactor Curaçao logic to be based on NL's subdiv CW

Additional context

N/A

arkid15r avatar Jun 30 '24 20:06 arkid15r

It seems logical to do the same for Aruba.

KJhellico avatar Jul 01 '24 10:07 KJhellico

It seems logical to do the same for Aruba.

Absolutely! I've updated the issue. Thanks!

arkid15r avatar Jul 01 '24 15:07 arkid15r

Quick question here: Isle of Man, Jersey, and Guernsey were previously callable as Great Britain subdivisions before 2007: https://en.wikipedia.org/wiki/ISO_3166-2:GB as GB-IOM, GB-GSY, and GB-JSY respectively. Should these entities get the same treatment, too?

Ideally, we should have ways to call up the appropriate holiday codes rather than folding them into the main entities. That would be great here.

PPsyrius avatar Sep 05 '24 05:09 PPsyrius