vacanza
Add Fiji holidays
Links:
- https://www.fiji.gov.fj/About-Fiji/Public-Holidays
- https://www.timeanddate.com/holidays/fiji/
- https://en.wikipedia.org/wiki/List_of_festivals_in_Fiji
Is there any progress in this?
I've just finished with Samoa and I'm going to work on Fiji holidays next.
@Prateekshit73 I know @kasya had started this task but didn't create a PR. Maybe you should combine the efforts or at least reuse the work already done.
@kasya could you share the code you wrote for Fiji?
Hi @kasya,
I hope you're doing well. I wanted to follow up on my previous request regarding the Fiji holidays task. It’s been a month since I reached out, and I haven’t heard back yet. If you could share any code or progress you’ve made, it would really help me move forward with this.
Thank you!
Hi @Prateekshit73 ! Sorry for a long silence from me! Just pushed what I have to a branch in my fork - https://github.com/kasya/python-holidays/tree/add-fiji-holidays I commented out some tests that were failing in order to push the changes, but once you uncomment those you'll see there are I think 2 tests that are failing, and they are connected to how the holidays are observed for the country.
Thank you!
Thank you for sharing the branch and your progress on the Fiji holidays! I appreciate your work on this.
I will take a look at the code and the failing tests you mentioned. Once I understand the issues, I’ll work on addressing them. If I have any questions, I’ll be sure to reach out.
Thanks again for your efforts!
As I was reviewing the Fiji holidays, I noticed that some holidays listed on Wikipedia are not present on the Fiji government website. Should we consider including these holidays?
Additionally, since I’m working on your fork, @kasya, should I create the pull request (PR) in your fork or in my own fork of the main repository?
Thanks for your guidance!
As I was reviewing the Fiji holidays, I noticed that some holidays listed on Wikipedia are not present on the Fiji government website. Should we consider including these holidays?
We can use UNOFFICIAL for non-official observances if you wish to implement them i.e. BlueSky Fiji Music Festival as mentioned on Wikipedia.
Alternatively, WORKDAY works as well if they're at least recognised by the local government in certain capacities i.e. a "Teacher's Day" or "Mother's Day" in other countries that's while officially recognised, isn't given a day-off.
Additionally, since I’m working on your fork, @kasya, should I create the pull request (PR) in your fork or in my own fork of the main repository?
No, create a PR for the main repository. Just keep @kasya as a co-author using commit message trailers.
I noticed that the following holidays are listed as not a public holiday on Wikipedia: Maha Shivaratri, Holi, Ram Navami, Hanuman Jayanti, Palm Sunday, Bula Festival, Hibiscus Carnival/Festival, Friendly North Festival, Krishna Janmashtami, Sugar Festival, Coral Coast Festival, Navaratri, and BlueSky Fiji Music Festival.
Should we implement these holidays similarly to how we handle the Maha Shivaratri holiday in Sri Lanka?
Looking forward to your thoughts!
I noticed that the following holidays are listed as
not a public holidayon Wikipedia: Maha Shivaratri, Holi, Ram Navami, Hanuman Jayanti, Palm Sunday,
Bula Festival, Hibiscus Carnival/Festival, Friendly North Festival, Sugar Festival, Coral Coast Festival - these are local holidays (celebrated in certain cities). I wouldn't add the rest of the non-public holidays either, as it's unlikely to be easy to find any source of their exact dates.
