tenants2
tenants2 copied to clipboard
The JustFix tenant platform!
Ugh. Right now Lob explodes if we give it an address that lacks a zip code, and this can happen with NYC addresses if NYC planning labs' geosearch was down...
Reviewing https://github.com/JustFixNYC/who-owns-what/pull/443 made me realize that there's a need for this handy component (see e.g. #1545 for some explanation of its usefulness) in our other codebases. It might be nice...
The `OnboardingInfo.address_verified` field was meant to track whether the address the user entered was verified on the server-side _and_ shown to the user for their consent (if it differed from...
This isn't a very big deal right now because the only navbar menu we have is the developer menu, which isn't visible on production, but it will become an issue...
In #1920, we fixed an issue where the parameters in a Python string were included within the parenthesis used to demark internationalization. Let's make a linting rule to try and...
Aside from pipenv being really slow, confusing, [overly eager to upgrade dependencies](https://github.com/JustFixNYC/tenants2/issues/69#issue-355143090), and some other things, poetry has really pretty docs: https://python-poetry.org/
In #1895 we made some of our rare edge-case error messages more human-friendly and internationalized them, but only for EFNY. Identical error messages exist in other parts of our code...
Wow before #1887, the demo deployment exploded with the following traceback: ```pytb Traceback (most recent call last): File "/usr/local/lib/python3.8/site-packages/django/core/handlers/base.py", line 113, in _get_response response = wrapped_callback(request, *callback_args, **callback_kwargs) File "/tenants2/evictionfree/views.py",...
The checkboxes are flex containers whose text is set to be vertically centered within them, but this ends up resulting in odd vertical spacing for multi-line labels vs. single-line ones....
A bunch of code was added in https://github.com/JustFixNYC/tenants2/pull/1858 and #1868, and most of it has test coverage, but some of it doesn't. It'd be nice to add more.