Josh van Leeuwen comments

Results 287 comments of


                                            Josh van Leeuwen

Version checker seems to pick the wrong latest version on multi-arch images when using SHA

This is a tricky one. There is a couple things going on here. First thing I noticed was that we are not handling paging properly in most/all our clients. I...

Replaced `docker` with `image`

/lgtm

Resolve SHA256 to tags automatically if the images specified in the k8s manifests doesn't contain tag.

Hmm, the problem with this is that multiple tags can be assigned to the same sha. In this current implementation we are just taking the first we come across. This...

Support Google Artifact Registry

/lgtm

Support Google Artifact Registry

/approve

Issue 66 - AWS ECR Credentials

Thanks @chelomontilla , apologies for the delay on this. /lgtm /hold Let’s merge when we are ready to release v0.3.0

Adds paging and obtaining the OS and Arch in the quay client

/assign @davidcollom

WIP:Add architecture and os checks when fetching tags

/hold /approve /lgtm

Wrong url path for token in selfhosted client

Thanks @kashtan404, Is this using a selfhosted instance of Jfrog, or the cloud hosted solution?

csr readiness probe failed, istio ingress pod also failed

Thanks @mvkzzz, can you please also share the logs of istio-csr?